Skip to content

Changed exception to not be reported as error but thrown #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

Changed exception to not be reported as error but thrown #304

merged 1 commit into from
Aug 2, 2018

Conversation

darrelmiller
Copy link
Member

@darrelmiller darrelmiller commented Aug 1, 2018 •
edited
Loading

Addresses #302

@darrelmiller darrelmiller requested a review from Shwetap05 August 1, 2018 20:04
Shwetap05
Shwetap05 approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@Shwetap05 Shwetap05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@darrelmiller darrelmiller merged commit 8e71804 into vnext Aug 2, 2018
@darrelmiller darrelmiller deleted the dm/versionerror branch August 2, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Shwetap05 Shwetap05 Shwetap05 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrelmiller @Shwetap05