vNext merge of #322 #325
Merged
vNext merge of #322 #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix WriteValue for DateTimeOffset type to convert to write as string with specific format. This will force it to be written just like string (ie. with double-quotes in JSON and single-quotes in YAML.) - Add Tests
PerthCharern
added
the
bug-fix-vNext
|
@Shwetap05 This process seems a little troublesome. We'll need two reviews for every bug fix. |
|
@PerthCharen This shouldn't need extensive review as its just a merge, i will make sure to sign off quick on these, sorry for delay this time. In reply to: 425599833 [](ancestors = 425599833) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #322