Skip to content

Ensure parsing null in "in" in Parameter does not fail #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PerthCharern
Copy link
Contributor

@PerthCharern PerthCharern commented Oct 9, 2018

Fix #309, #297

  • Ensure that null in "in" in parameter object is parsed to a null Im in the DOM.

  • Add validation rule to validate the required fields in Parameter.

… in the DOM.

- Add validation rule to validate the required fields in Parameter.
Add a few more tests
{
context.CreateError(
nameof(RequiredMustBeTrueWhenInIsPath),
"\"required\" must be true when parameter location is path");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path [](start = 82, length = 4)

in quotes

Copy link
Member

@Shwetap05 Shwetap05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@PerthCharern PerthCharern merged commit f1864c6 into master Oct 12, 2018
@PerthCharern PerthCharern deleted the perthcharern/AllowParsingNullForParameterLocation branch October 12, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants