Parsing IOpenApiAny should respect format and type #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e'll try to convert. - If type exists, then respect the type. If data conflicts with the type, throw an error. - If type doesn't exist, use best effort.
- add handling for compelx type
- Fix culture. - Move Field Map parameters out to their own files.
- Don't throw inside the convertor
Handle Example in MediaType and Parameter in V3
add more tests
fix the response deserializer
|
This changeset turned out to be much larger than I originally expected, as I kept going down the rabbit hole after discovering more and more nuances from the spec and the V2/V3 discrepancies. @darrelmiller It's ready for review now. Apologies for the PR size - on the upside, half of the files are tests and the remaining, except a few files, contain straightforward changes, so hopefully this is not too bad to review. |
darrelmiller
reviewed
Nov 7, 2018
| new AnyListFieldMap<OpenApiParameter> | ||
| { | ||
| { | ||
| "enum", |
There was a problem hiding this comment.
Probably would be good to have these as constants #Resolved
darrelmiller
approved these changes
Nov 7, 2018
|
Thanks for the review @darrelmiller! |
Merged
PerthCharern
deleted the
perthcharern/ParsingAnyShouldRespectFormatAndType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #306
Parse IOpenApiAny with respect to
typeandformatThis handles parsingdefault,enum,example, andexamplesin both V2 and V3.Validation rules added to validate whether there is a mismatch between the given type and the data itself.
The code is quite involved given that the schema type/format information may not reside at the same level as the Any itself (e.g. the Any deep down in
examplesfield in media type needs information formschemafield).