Align hidi params with kiota #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieKimani1
requested review from
danielmbaluka,
darrelmiller,
baywet and
irvinesunday
baywet
requested changes
Jan 24, 2022
There was a problem hiding this comment.
hold before you merge please!
see this comment on other differences #662 (comment)
@baywet Implemented! |
baywet
requested changes
Feb 1, 2022
baywet
requested changes
Feb 1, 2022
| }; | ||
| transformCommand.Handler = CommandHandler.Create<string, FileInfo, OpenApiSpecVersion?, OpenApiFormat?, string, string, string, bool, bool>( | ||
|
|
||
| transformCommand.Handler = CommandHandler.Create<string, FileInfo, OpenApiSpecVersion?, OpenApiFormat?, LogLevel, string, string, string, bool, bool>( | ||
| OpenApiService.ProcessOpenApiDocument); |
There was a problem hiding this comment.
Suggested change
| OpenApiService.ProcessOpenApiDocument); | |
| await OpenApiService.ProcessOpenApiDocument); |
There was a problem hiding this comment.
ah ignore my confused self, but please double check the system.commandline API recognizes it's now a tasks and blocks on it, I ran into that issue with kiota a while ago and this leads to very confusing behaviours
There was a problem hiding this comment.
Using the await keyword throws the error cannot await "method group"
There was a problem hiding this comment.
Yep sorry, as long as the command invoke blocks on the task we're good
baywet
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Kiota's documentation, this PR seeks to align the common parameters between Hidi and Kiota in order to reduce any disparity in the tools.
As of now, these parameters are:
--openapiin Kiota vs--inputin Hidi representing the path to the OpenAPI description/CSDL file used to generate the code files--outputin Kiota vs--outputin Hidi representing the output directory path for the generated code filesThis PR also seeks to add aliases to our existing parameters for simplicity
Fixes #662