Skip to content

Conversation

darrelmiller
Copy link
Member

  • Removed usage of HttpClient to download example OpenAPI descriptions
  • Added some new sample OpenAPI documents
  • Re-enabled some tests relating to examples
  • Switched some asserts to use fluent assertions.

@msftclas
Copy link

@darrelmiller,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


public OpenApiExampleTests()
[Fact()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() [](start = 13, length = 2)

Not sure what the impact of having this bracket here is :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's left over from me removing the skip parameter. I'll get rid of it.

@PerthCharern
Copy link
Contributor

                     c.Example = new OpenApiString("xyz"); ///"{ \"foo\": \"bar\" }"; This doesn't work because parser treats it as a node

Remove this comment. We should add more tests with types other than OpenApiString in the Example property.


Refers to: test/Microsoft.OpenApi.Tests/ExampleTests.cs:40 in 7f06092. [](commit_id = 7f06092, deletion_comment = False)

Copy link
Contributor

@PerthCharern PerthCharern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@darrelmiller darrelmiller merged commit 342f79e into master Nov 13, 2017
@darrelmiller darrelmiller deleted the dm/fixed-example-tests branch November 13, 2017 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants