Skip to content

Fix handling of numerical configuration properties across PS5 and PS7 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fix handling of numerical configuration properties across PS5 and PS7 #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions GitHubConfiguration.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,16 +466,18 @@ function Resolve-PropertyValue
if ($Type -eq 'Boolean') { $typeType = [Boolean] }
if ($Type -eq 'Int32') { $typeType = [Int32] }
if ($Type -eq 'Int64') { $typeType = [Int64] }
$numberEquivalents = @('Int32', 'Int64', 'long', 'int')

if (Test-PropertyExists -InputObject $InputObject -Name $Name)
{
if ($InputObject.$Name -is $typeType)
if (($InputObject.$Name -is $typeType) -or
(($Type -in $numberEquivalents) -and ($InputObject.$Name.GetType().Name -in $numberEquivalents)))
{
return $InputObject.$Name
}
else
{
$message = "The locally cached $Name configuration was not of type $Type. Reverting to default value."
$message = "The locally cached $Name configuration was not of type $Type (it was $($InputObject.$Name.GetType())). Reverting to default value."
Write-Log -Message $message -Level Warning
return $DefaultValue
}
Expand Down