Skip to content

Revert "New/Set-GitHubRepository: Add AllowAutoMerge and UseSquashPrTitleAsDefault Parameters" #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

HowardWolosky
Copy link
Contributor

Reverts #358

It turns out that this isn't quite working right.

The use_squash_pr_title_as_default parameter has been deprecated per the documentation in favor of squash_merge_commit_title which works a bit differently.

Additionally, there appears to be a GitHub-side bug at the moment with changing the value of allow_auto_merge (it does not honor the request being sent).

Given this, for the time being we'll revert the change until we know that the feature is working correctly.

/cc: @X-Guardian

@HowardWolosky HowardWolosky merged commit 515e9be into master Dec 15, 2022
@HowardWolosky HowardWolosky deleted the revert-358-issue-357 branch December 15, 2022 23:32
@X-Guardian
Copy link
Contributor

I will raise new PRs for these, splitting each one into its own PR. I have just tested my original code for the allow_auto_merge setting on both the new and set cmdlets and it is working fine for me now, so it was probably a transient issue with GitHub when you tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants