Remove static analysis warning for using a module alias being referenced in a test #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced in a test I generally don't like aliases being used (neither does PSScriptAnalyzer), but in this case, `New-GitHubDeploymentEnvironment` was writting to be able to behave as `Set-GitHubDeploymentEnvironment` as well, and we should be testing it the way that a user would likely be calling it.
HowardWolosky
added
the
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I generally don't like aliases being used (neither does PSScriptAnalyzer), but in this case,
New-GitHubDeploymentEnvironmentwas writting to be able to behave asSet-GitHubDeploymentEnvironmentas well, and we should be testing it the way that a user would likely be calling it.Checklist
[ ] Comment-based help added/updated, including examples.[ ] New/changed code adheres to our coding guidelines.[ ] Formatters were created for any new types being added.[ ] New/changed code continues to support the pipeline.[ ] Changes to the manifest file follow the manifest guidance.[ ] Relevant usage examples have been added/updated in USAGE.md.[ ] If desired, ensure your name is added to our Contributors list