-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color picker - Lab format: use roundoff optional #13603
Comments
Hi, I want to try to make this feature, please assign this to me. Thanks. |
@wbalbo Thanks. you are now assigned. Do you have an estimated finish time on this? BTW, please raise a draft PR (pull request) once this is a WIP. Thank you for your contribution! |
Thanks, I don't have an estimated finish time, but I will try to do it this weekend and next week, hopefully will not be too long to finish. |
I'm sorry, I got busy these last weeks and didn't have time to see this issue properly. Maybe is better to assign to other people, sorry. |
cc: @crutkas |
Optional rounding for all seems like best to me…like shown below and set as default.
Tho most other colors numbers usually don’t have decimal places; perhaps only applies to CIE Lab and XYZ
Thanks
Doug
From: Pierpaolo ***@***.***>
Sent: Saturday, November 6, 2021 8:41 AM
To: microsoft/PowerToys ***@***.***>
Cc: drms ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/PowerToys] Color picker - Lab format: use roundoff optional (#13603)
Hey everyone, I can do it.
Some questions.
Should we round to 0 by default without giving any options both for CIELAB and CIEXYZ? Or maybe it's better to make that as an option? Option should be only for that two formats, single or shared?
Or maybe even for all formats? Like this?
<https://user-images.githubusercontent.com/6475341/140609854-82d00ecd-a3cb-4472-a151-b92eb79c1b58.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#13603 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4EVUI6VNHH2BXY6PA7FHLUKUO4PANCNFSM5FH5COSQ> .
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . <https://github.com/notifications/beacon/AA4EVUJNUFZV7JVNAGNB2A3UKUO4PA5CNFSM5FH5COS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHFO4D7Y.gif>
|
What other thing uses a floating number? Limit only to this |
Another issue this would address is the way the CIELab hover display bounces around as you move the mouse over different colours. This is especially distracting when hovering over a photo as minor changes in colour produce big changes in the placement of the numbers and in the total width of the hover. This makes it hard to read and compare Lab values as you move the mouse because the numbers are jumping around horizontally all the time. The reason seems to be that the number of decimal places changes, and sometimes Lab values are positive or negative. I recommend:
It would also be nice to abbreviate "CIELab" to "Lab" in the hover window to save space. Getting live LAB readouts from the display is fantastic, fixing up this issue would be the icing on the cake. 🎂 |
This issue seems to be related to: #14863 |
Agree with yellowtailfan comments. |
A sample average feature would be a great thing to have, I agree! 👍 |
Description of the new feature / enhancement
Love ability to use Lab color mode. I even discovered ability to zoom...very handy too.
But, suggest you give users ability/option to have NO decimal point accuracy. Instead have option to see rounded-off whole numbers...
for example: 75, -19, 16 instead of 75.37, -19.4, 15.7
Why? Because decimal accuracy rarely needed (but if desired, set option to see decimals) and when displayed as whole numbers it is far easier and faster to understand the colors. Decimals make our brains think/convert/interpret when it is not needed and adds confusion.
Thanks, Doug
Scenario when this would be used?
I use color sampling of on screen images (not already in Photoshop or other image program) to check colors and see if correct or if desired for future uses....very often every day,
And I use Lab as I know instantly the brightness and color (which you cannot do using RGB or other color spaces...because Lab separates colors from luminosity)
Accuracy to whole numbers is quite sufficient and much faster to "read" by the numbers.
Supporting information
Ask anyone who regularly uses Lab. Dan Margulis is the Lab master; see his books.
The text was updated successfully, but these errors were encountered: