Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker - Lab format: use roundoff optional #13603

Open
drms opened this issue Oct 3, 2021 · 13 comments
Open

Color picker - Lab format: use roundoff optional #13603

drms opened this issue Oct 3, 2021 · 13 comments
Labels
Good first issue Good for newcomers. Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility

Comments

@drms
Copy link

drms commented Oct 3, 2021

Description of the new feature / enhancement

Love ability to use Lab color mode. I even discovered ability to zoom...very handy too.

But, suggest you give users ability/option to have NO decimal point accuracy. Instead have option to see rounded-off whole numbers...
for example: 75, -19, 16 instead of 75.37, -19.4, 15.7

Why? Because decimal accuracy rarely needed (but if desired, set option to see decimals) and when displayed as whole numbers it is far easier and faster to understand the colors. Decimals make our brains think/convert/interpret when it is not needed and adds confusion.

Thanks, Doug

Lab decimals

Lab decimals

Scenario when this would be used?

I use color sampling of on screen images (not already in Photoshop or other image program) to check colors and see if correct or if desired for future uses....very often every day,
And I use Lab as I know instantly the brightness and color (which you cannot do using RGB or other color spaces...because Lab separates colors from luminosity)
Accuracy to whole numbers is quite sufficient and much faster to "read" by the numbers.

Supporting information

Ask anyone who regularly uses Lab. Dan Margulis is the Lab master; see his books.

@drms drms added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Oct 3, 2021
@crutkas crutkas added Good first issue Good for newcomers. Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 4, 2021
@crutkas crutkas changed the title Lab: use roundoff optional Color picker - Lab format: use roundoff optional Oct 4, 2021
@wbalbo
Copy link

wbalbo commented Oct 22, 2021

Hi, I want to try to make this feature, please assign this to me.

Thanks.

@franky920920
Copy link
Contributor

@wbalbo Thanks. you are now assigned. Do you have an estimated finish time on this? BTW, please raise a draft PR (pull request) once this is a WIP.

Thank you for your contribution!

@franky920920 franky920920 added the Status-In progress This issue or work-item is under development label Oct 22, 2021
@wbalbo
Copy link

wbalbo commented Oct 22, 2021

@wbalbo Thanks. you are now assigned. Do you have an estimated finish time on this? BTW, please raise a draft PR (pull request) once this is a WIP.

Thank you for your contribution!

Thanks, I don't have an estimated finish time, but I will try to do it this weekend and next week, hopefully will not be too long to finish.

@wbalbo
Copy link

wbalbo commented Nov 4, 2021

I'm sorry, I got busy these last weeks and didn't have time to see this issue properly.

Maybe is better to assign to other people, sorry.

@wbalbo wbalbo removed their assignment Nov 4, 2021
@franky920920 franky920920 removed the Status-In progress This issue or work-item is under development label Nov 4, 2021
@peerpalo
Copy link
Contributor

peerpalo commented Nov 6, 2021

Hey everyone, I can do it.

Some questions.

Should we round to 0 by default without giving any options both for CIELAB and CIEXYZ? Or maybe it's better to make that as an option? Option should be only for that two formats, single or shared?

Or maybe even for all formats? Like this?

immagine

@franky920920
Copy link
Contributor

Hey everyone, I can do it.

Some questions.

Should we round to 0 by default without giving any options both for CIELAB and CIEXYZ? Or maybe it's better to make that as an option? Option should be only for that two formats, single or shared?

Or maybe even for all formats? Like this?

immagine

cc: @crutkas

@drms
Copy link
Author

drms commented Nov 6, 2021 via email

@crutkas
Copy link
Member

crutkas commented Nov 6, 2021

What other thing uses a floating number? Limit only to this

@peerpalo
Copy link
Contributor

peerpalo commented Nov 7, 2021

What other thing uses a floating number? Limit only to this

Ok, in that case I need some UX guidance. It's better put a checkbox in menu flyout only for those two formats? What do you think? Of course setting in that case will be different for each format

image

@yellowtailfan
Copy link

Another issue this would address is the way the CIELab hover display bounces around as you move the mouse over different colours. This is especially distracting when hovering over a photo as minor changes in colour produce big changes in the placement of the numbers and in the total width of the hover. This makes it hard to read and compare Lab values as you move the mouse because the numbers are jumping around horizontally all the time.

The reason seems to be that the number of decimal places changes, and sometimes Lab values are positive or negative. I recommend:

  1. Making the default display have fixed precision with a single decimal place for all three Lab values
  2. Align the numbers so that they don't bounce around with changes in value or sign
  3. Adding an option to adjust the precision or round to integers (optional)

It would also be nice to abbreviate "CIELab" to "Lab" in the hover window to save space.

Getting live LAB readouts from the display is fantastic, fixing up this issue would be the icing on the cake. 🎂

@yellowtailfan
Copy link

This issue seems to be related to: #14863

@drms
Copy link
Author

drms commented Jul 13, 2023

Agree with yellowtailfan comments.
Perhaps an option to choose 1 pixel sample or avg of 3 or 5 or 9 etc. (like Photoshop and most all other graphics programs) would resolve fast value changes with mouse motion and avoid single sample errors.
But don't remove the very useful zoom to selection of mouse pointer.

@yellowtailfan
Copy link

A sample average feature would be a great thing to have, I agree! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers. Idea-Enhancement New feature or request on an existing product Product-Color Picker All things around the Color Picker utility
Projects
Status: No status
Development

No branches or pull requests

6 participants