Web Search crash with Firefox

[xiwang66]

Microsoft PowerToys version

0.60.0

Running as admin

• Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

• Set the default browser as Firefox
• run powertoys run, type in some keyword
• hit web search

✔️ Expected Behavior

Firefox open and search the keyword

❌ Actual Behavior

An error message shows up that "Failed to open Firefox"

This function works well with Chrome or Edge

Other Software

No response

[Aaron-Junker]

/bugreport

[ghost]

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!

[xiwang66]

PowerToysReport_2022-07-09-08-49-11.zip

[xiwang66]

another minor related issue. If I change the default browser in the windows setting, say from Chrome to Firefox. The web search plugin doesn't recognize this change right away. It will still use Chrome as default. I need to close and reopen PowerToys to make the change take effect.

[jaimecbernardo]

This is ... interesting?

[2022-07-09 08:49:01.8710] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Wox.Infrastructure\Helper.cs::189]
-------------------------- Begin exception --------------------------
Message: Unable to open C:\Program: An error occurred trying to start process 'C:\Program' with working directory 'C:\Program Files\PowerToys'. The system cannot find the file specified.

Exception full name  : System.ComponentModel.Win32Exception
Exception message    : An error occurred trying to start process 'C:\Program' with working directory 'C:\Program Files\PowerToys'. The system cannot find the file specified.
Exception stack trace:
   at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Wox.Infrastructure.Helper.OpenInShell(String path, String arguments, String workingDir, ShellRunAsType runAs, Boolean runWithHiddenWindow)
Exception source     : System.Diagnostics.Process
Exception target site: Boolean StartWithShellExecuteEx(System.Diagnostics.ProcessStartInfo)
Exception HResult    : -2147467259
-------------------------- End exception --------------------------


[2022-07-09 08:49:01.8710] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Plugins\Community.PowerToys.Run.Plugin.WebSearch\Main.cs::177]
Failed to open Firefox.

[jaimecbernardo]

Hi @xiwang66

Could you please check your registry for what's in "ProgId" in "Computer\HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\Shell\Associations\UrlAssociations\http\UserChoice"?

In my case it's ChromeHTML, for example.

Then, can you please check "Computer\HKEY_CLASSES_ROOT{progId}\shell\open\command" and send what's there ,as well?

Something seems to not be playing well with our code to recognize the default browser and how to call it.

Please send us these values for when you have Firefox, Chrome, and Edge.

/needinfo

[xiwang66]

[xiwang66]

@jaimecbernardo pic attached. Something is wrong with the ProgId it seems...

Firefox has one version in the Windows store, the other exe installer. The pic for Windows store version "Computer\HKEY_CLASSES_ROOT{progId}\shell\open\command" is attached. With this setting, powertoys crash .....

Then I uninstall it and install the exe version for testing. This time everything works fine. So it is only the Windows store Firefox has this issue.

[jaimecbernardo]

I don't think it's ProgId. I think it's the command (Default). Notice how Chrome has " and Firefox doesn't?
Can you please send that value for the others as well? Like, full values, it's getting cut on your screenshot.

[jaimecbernardo]

/needinfo

[xiwang66]

@jaimecbernardo
Hello. It is attached.

C:\Program Files\WindowsApps\Mozilla.Firefox_102.0.1.0_x64__n80bbvh6b1yt2\VFS\ProgramFiles\Firefox Package Root\firefox.exe -osint -url "%1"

"C:\Program Files\Google\Chrome\Application\chrome.exe" --single-argument %1

[sosssego]

The lack of quotes in the command around the firefox executable path makes the problem show up.