Power Launcher fix Firefox command path #20350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecbernardo
requested changes
Sep 7, 2022
crutkas
added
the
Needs-Review
jaimecbernardo
approved these changes
Sep 20, 2022
jaimecbernardo
requested changes
Sep 20, 2022
Hack to fix command path for firefox installed through Microsoft Store
jaimecbernardo
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround to fix command path for Firefox installed through Microsoft Store
Summary of the Pull Request
When Firefox is installed through Microsoft Store its registry command path is not between quotes.
as discussed #19260.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The change looks for the registry key that does not contain quotes and contains firefox.exe
Adds the quotes for the command and lets the rest of the code deals with it.
Validation Steps Performed
Tested it manually testing that power run web search works with Firefox installed through Microsoft Store.
And tested it works ok for other browsers and Firefox installed from the .exe