-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement P0738R2 istream_iterator cleanup #246
Conversation
95bfc03
to
97f00ea
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines claims that |
c0219ae
to
9797af1
Compare
Casey approved this in the MSVC-internal repo where it has been successfully committed, so I'm going to go ahead and merge this here with administrator powers. |
Thanks for the feature implementation! This will show up in the next update of our status chart :-) |
Description
This addresses #35 implementing P0738R2
I went for the ugly solution with an
_HAS_CXX20
ifdef. The cleaner solution would certainly be to utilize member initialization and simply default the default constructor. However I assume that this is not a backward compatible change.Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.