Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement P0738R2 istream_iterator cleanup #246

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Nov 1, 2019

Description

This addresses #35 implementing P0738R2

I went for the ugly solution with an _HAS_CXX20 ifdef. The cleaner solution would certainly be to utilize member initialization and simply default the default constructor. However I assume that this is not a backward compatible change.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
@miscco miscco force-pushed the istream branch 2 times, most recently from 95bfc03 to 97f00ea Compare November 2, 2019 09:59
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
stl/inc/iterator Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Copy link
Member

Azure Pipelines claims that <iterator> needs to be clang-formatted. (#255 will improve our diagnostics, telling us what code needs to be changed.)

stl/inc/iterator Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Casey approved this in the MSVC-internal repo where it has been successfully committed, so I'm going to go ahead and merge this here with administrator powers.

@StephanTLavavej StephanTLavavej merged commit f9b1dcc into microsoft:master Nov 7, 2019
@StephanTLavavej
Copy link
Member

Thanks for the feature implementation! This will show up in the next update of our status chart :-)

@miscco miscco deleted the istream branch November 8, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants