Make enforce-clang-format.cmd also run git diff.
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
StephanTLavavej
force-pushed
the
git_diff
branch
from
5b51fec
to
d58adaf
Compare
|
@BillyONeal, my intentionally failing run (original PR) looked great. When I force-pushed the change that's intended to succeed, clang-format appears to be hanging with "Waiting for console output...". Do you know why this is happening? I don't like sporadic failures. |
|
The Azure Pipelines run after I pushed the 5-minute timeout here succeeded, but now I observe #246 also hanging on enforce-clang-format. Something is wrong. |
4 tasks
|
I filed #257 for the sporadic clang-format hang. The hang is pre-existing and not caused by this PR. |
BillyONeal
approved these changes
Nov 5, 2019
barcharcraz
suggested changes
Nov 5, 2019
This is provided by azure-pipelines.yml. See: microsoft#114 (comment)
StephanTLavavej
force-pushed
the
git_diff
branch
from
77b23e1
to
a178840
Compare
barcharcraz
approved these changes
Nov 5, 2019
fengjixuchui
added a commit
to fengjixuchui/STL
that referenced
this pull request
Nov 6, 2019
Make enforce-clang-format.cmd also run `git diff`. (microsoft#255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make enforce-clang-format.cmd also run
git diff.This will produce more informative output for clang-format failures.
Also add 5-minute timeouts to every task in
run_build.ymlexcept'Install MSVC Preview'. This number was chosen semi-arbitrarily (successful runs appear to have sub-1-minute times for each task).Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.