Missing `error` event

[falsandtru]

Window's error event should come from https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/browser.webidl.xml#L12798, but it is missing with the generated .d.ts file.

https://github.com/Microsoft/TSJS-lib-generator/blob/master/baselines/dom.generated.d.ts#L13045

@zhengbli Can you take a look?

cc @saschanaz for your pr.

[falsandtru]

Ah, now TS.fsx is maintained by @mhegazy as the only committer? Can you take a look instead of him?

[saschanaz]

This is because the onerror event property has a special handler named ErrorEventHandler instead of normal EventHandler. TS.fsx (incorrectly) checks only for EventHandler thus the error event is omitted.

[falsandtru]

Thanks for letting me know!

[saschanaz]

It seems touch* events on Window interface are also affected.

[thw0rted]

Is there a reason why the generated GlobalEventHandlers entries all look like

    ondurationchange: ((this: GlobalEventHandlers, ev: Event) => any) | null;

except for onerror, which is just ErrorEventHandler, without allowing for null? Is it actually not legal to un-register the error handler by setting window.onerror = null?

If this is incorrect, should I open a separate issue to fix it?

[saschanaz]

should I open a separate issue to fix it?

@thw0rted Yes, please do.