Skip to content

feat: add the ability override extended interfaces, fixes HTMLElement onerror type #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

feat: add the ability override extended interfaces, fixes HTMLElement onerror type #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9dffbc8
added override and updated onerror for htmlelement
cosmic-pixel-painter Sep 12, 2025
9ece70d
added clarifying comments
cosmic-pixel-painter Sep 13, 2025
fc80646
added addEventListener override
cosmic-pixel-painter Sep 14, 2025
6ade076
added comments
cosmic-pixel-painter Sep 14, 2025
758e36c
added override for svgelement
cosmic-pixel-painter Sep 14, 2025
6893423
updated svgsvgelement
cosmic-pixel-painter Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14026,7 +14026,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
*/
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/**
* The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
*
Expand Down Expand Up @@ -14117,6 +14117,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
*/
readonly offsetWidth: number;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
*
Expand Down Expand Up @@ -14183,6 +14190,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -27386,9 +27399,16 @@ interface SVGElementEventMap extends ElementEventMap, GlobalEventHandlersEventMa
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement)
*/
interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers, HTMLOrSVGElement {
interface SVGElement extends Element, ElementCSSInlineStyle, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/** @deprecated */
readonly className: any;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`ownerSVGElement`** property of the SVGElement interface reflects the nearest ancestor svg element.
*
Expand All @@ -27401,6 +27421,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
*/
readonly viewportElement: SVGElement | null;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -29763,6 +29789,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
unsuspendRedraw(suspendHandleID: number): void;
/** @deprecated */
unsuspendRedrawAll(): void;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
36 changes: 34 additions & 2 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14013,7 +14013,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
*/
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/**
* The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
*
Expand Down Expand Up @@ -14104,6 +14104,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
*/
readonly offsetWidth: number;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
*
Expand Down Expand Up @@ -14170,6 +14177,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -27364,9 +27377,16 @@ interface SVGElementEventMap extends ElementEventMap, GlobalEventHandlersEventMa
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement)
*/
interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers, HTMLOrSVGElement {
interface SVGElement extends Element, ElementCSSInlineStyle, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/** @deprecated */
readonly className: any;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`ownerSVGElement`** property of the SVGElement interface reflects the nearest ancestor svg element.
*
Expand All @@ -27379,6 +27399,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
*/
readonly viewportElement: SVGElement | null;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -29741,6 +29767,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
unsuspendRedraw(suspendHandleID: number): void;
/** @deprecated */
unsuspendRedrawAll(): void;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
36 changes: 34 additions & 2 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14026,7 +14026,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
*/
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/**
* The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
*
Expand Down Expand Up @@ -14117,6 +14117,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
*/
readonly offsetWidth: number;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
*
Expand Down Expand Up @@ -14183,6 +14190,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
*/
togglePopover(options?: boolean): boolean;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -27386,9 +27399,16 @@ interface SVGElementEventMap extends ElementEventMap, GlobalEventHandlersEventMa
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement)
*/
interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers, HTMLOrSVGElement {
interface SVGElement extends Element, ElementCSSInlineStyle, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
/** @deprecated */
readonly className: any;
/**
* The error event is fired on an element when a resource failed to load, or can't be used.
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
*/
onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
/**
* The **`ownerSVGElement`** property of the SVGElement interface reflects the nearest ancestor svg element.
*
Expand All @@ -27401,6 +27421,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
*/
readonly viewportElement: SVGElement | null;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down Expand Up @@ -29763,6 +29789,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
unsuspendRedraw(suspendHandleID: number): void;
/** @deprecated */
unsuspendRedrawAll(): void;
/**
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
*
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
*/
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
Loading