Skip to content

Support typeParameters and overrideThis on interfaces #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Support typeParameters and overrideThis on interfaces #2159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bae2ca
Support typeParameters and overrideThis
Bashamega Sep 24, 2025
f908180
format
Bashamega Sep 24, 2025
d58be7f
Update
Bashamega Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
{
"mixins": {
"mixin": {
"MessageEventTarget": {
"typeParameters": [
{
"name": "T"
}
],
"overrideThis": "T"
},
"NavigatorGPU": {
"properties": {
"property": {
Expand Down
1 change: 1 addition & 0 deletions inputfiles/patches/message.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
interface-mixin MessageEventTarget overrideThis=T typeParameters=T
13 changes: 13 additions & 0 deletions src/build/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ function handleTyped(type: Node): Typed {
};
}

function handleTypeParameters(value: Value) {
if (!value) return {};
return {
typeParameters: [
{
name: string(value),
},
],
};
}

/**
* Converts patch files in KDL to match the [types](types.d.ts).
*/
Expand Down Expand Up @@ -171,6 +182,8 @@ function handleMixinandInterfaces(
properties: { property },
methods: { method },
...optionalMember("extends", "string", node.properties?.extends),
...optionalMember("overrideThis", "string", node.properties?.overrideThis),
...handleTypeParameters(node.properties?.typeParameters),
...interfaceObject,
} as DeepPartial<Interface>;
}
Expand Down