Support methods without names in interfaces #2169
Open
+13
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
reviewed
Sep 27, 2025
| // Keeping EventListener and EventListenerObject isn't the most elegant way to handle the event listeners, but we need to keep the EventListener as an extendable interface for libraries like angular. | ||
| interface EventListener noInterfaceObject=#true { | ||
| method callable { | ||
| type void |
There was a problem hiding this comment.
This is a good reason to use returns=void
saschanaz
reviewed
Sep 27, 2025
| @@ -0,0 +1,7 @@ | |||
| // Keeping EventListener and EventListenerObject isn't the most elegant way to handle the event listeners, but we need to keep the EventListener as an extendable interface for libraries like angular. | |||
| interface EventListener noInterfaceObject=#true { | |||
| method callable { | |||
There was a problem hiding this comment.
We already have interface.anonymouseMethods so use it with something like anonymous-method {}?
There was a problem hiding this comment.
Sure, I will update it
|
I have updated @saschanaz |
|
Ohno, I forgot that it was only for getters and stringifiers... sorry 🫠 But maybe |
Bashamega
changed the title
|
No issues @saschanaz |
saschanaz
reviewed
Sep 27, 2025
| ]; | ||
| return { name, signature }; | ||
| return { | ||
| ...optionalMember("name", "string", name), |
There was a problem hiding this comment.
Why should this be optionalMember?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2053
This PR adds support for methods without explicit names.
I got the name "callable", from the jsonc