Introduce CSSStyleDeclarationBase #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce DT breakage. But note that this would make `CSSPageDescriptors extends CSSStyleDeclaration` to `false`. Authors would need to use CSSStyleDeclarationBase for that.
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
CSSStyleDeclaration doesn't add anything to CSSStyleProperties so I think it technically still works? |
|
With this PR it's CSSStyleDeclarationBase -> CSSStyleProperties -> CSSStyleDeclaration, so yeah it can't add anything to it's now-parent. 
|
|
@jakebailey 🤞🏻 |
Bashamega
reviewed
Oct 1, 2025
Bashamega
reviewed
Oct 1, 2025
Bashamega
reviewed
Oct 1, 2025
|
Just a few nits that I found |
Bashamega
approved these changes
Oct 1, 2025
jakebailey
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Based on microsoft/TypeScript#62496, it seems like this is working fine. If you're happy, then I think this is okay.
|
LGTM, let's go 🙂 |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce DT breakage. But note that this would make
CSSPageDescriptors extends CSSStyleDeclarationtofalse. Authors would need to use CSSStyleDeclarationBase for that.