Make URLPatternResult properties mandatory #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Does |
|
Yarp. Good spot. |
|
LGTM, thanks! |
|
There was an issue merging, maybe try again saschanaz. Details |
jakebailey
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of those cases where a "return value" dictionary is being generated as an interface with optional properties.
These aren't explicitly marked as
requiredin the IDL, but are mandatorily assigned in the URLPattern spec. Having these as optional properties in TS is just going to be a usability headache.Refs: https://urlpattern.spec.whatwg.org/#url-pattern-match
Refs: DefinitelyTyped/DefinitelyTyped#73799 (comment)