Change SubtleCrypto method return types to Promise #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these methods returned PromiseLike, even though the spec has always required them to return real Promises and browsers have always done so. According to #60, this was done in order to work around #47; now that #47 has been fixed, this workaround is obsolete. This generally should not be a breaking change since it is making the SubtleCrypto type contract stricter and that API is generally implemented by the platform, not by users.
|
|
sandersn
approved these changes
Jun 12, 2020
|
Thanks for following up on this ancient issue @taymonbeal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these methods returned
PromiseLike, even though the spec has always required them to return realPromises and browsers have always done so. According to #60, this was done in order to work around #47; now that #47 has been fixed, this workaround is obsolete.This generally should not be a breaking change since it is making the
SubtleCryptotype contract stricter and that API is generally implemented by the platform, not by users.