Skip to content

cast highlighting inconsistent across many themes #375

@aeschli

Description

@aeschli

From @rob3c on November 28, 2016 21:51

  • VSCode Version: 1.8.0-insider Commit 2c8ab1a5ffc49ac26b2080bfbbbf9317fb8071bb
  • OS Version: Windows 8 Pro

Casting is inconsistently rendered across many themes. It seems related to newlines. Here's a code sample (with excessive casting) and screenshots across a few themes, for reference. (even the github renderer seems confused!)

class Foo {
    constructor(public x: string) {}
}

const foo1 = <Foo> { x: '1' };
const foo2 = <Foo> {
    x: '2'
};
const foo3 =
    <Foo> {
        x: '3'
    };

let foos: Foo[] = <Foo[]> [
    new Foo('4'),
    <Foo>{ x: '5' },
    <Foo>{
        x: '6'
    },
];

let obj = Object.assign(new Foo('7'), <Foo> { x: '8' },
    <Foo>{ x: '9' }, <Foo> { x: '10' }, <Foo>{
        x: '11'
    },
    <Foo>{
        x: '12'
    });

Dark+

dark theme casting

Light+

light theme casting

Monokai Dimmed

monokai dimmed theme casting

Monokai

monokai theme casting

Solarized Dark

solarized dark theme casting

Copied from original issue: microsoft/vscode#16175

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions