Skip to content

Conversation

zhengbli
Copy link
Contributor

No description provided.

@zhengbli zhengbli force-pushed the addTests branch 3 times, most recently from fff044c to c9c26de Compare November 19, 2015 22:40
@@ -0,0 +1,4 @@
// Place your settings in this file to overwrite default and user settings.
{
"editor.insertSpaces": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically, this uses tabs. 😄

Change to 4 spaces I guess.

@DanielRosenwasser
Copy link
Member

We shouldn't be committing the .d.ts files in typings - it's usually better practice to commit the tsd.json.

@zhengbli
Copy link
Contributor Author

@DanielRosenwasser any other comments?

}

for (var file of fs.readdirSync('cases')) {
var text = fs.readFileSync('cases/' + file, 'utf8');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use path.join

zhengbli added a commit that referenced this pull request Dec 2, 2015
@zhengbli zhengbli merged commit 4c720ef into master Dec 2, 2015
@zhengbli zhengbli deleted the addTests branch December 2, 2015 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants