Skip to content

add 'from' keyword #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2016
Merged

add 'from' keyword #34

merged 1 commit into from
Feb 2, 2016

Conversation

gheoan
Copy link
Contributor

@gheoan gheoan commented Jan 5, 2016

No description provided.

@msftclas
Copy link

msftclas commented Jan 5, 2016

Hi @gheoan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Feb 2, 2016

@gheoan, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. PackageDev generates it like that. Maybe because I'm on Windows. I will manually remove it.

@gheoan
Copy link
Contributor Author

gheoan commented Feb 2, 2016

@zhengbli rebased and ready to merge

zhengbli added a commit that referenced this pull request Feb 2, 2016
@zhengbli zhengbli merged commit 82a19fe into microsoft:master Feb 2, 2016
@zhengbli
Copy link
Contributor

zhengbli commented Feb 2, 2016

@gheoan Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants