Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing playwright #2619

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Removing playwright #2619

merged 1 commit into from
Nov 29, 2022

Conversation

navya9singh
Copy link
Member

No description provided.

@andrewbranch
Copy link
Member

Context: We’re removing the PDF and ePub handbook generation because the playwright dependency is constantly causing build errors both in CI and in local development and slowing down every build. There are ways we can improve the process and generate these assets without playwright (perhaps without native dependencies), but we were skeptical of the value they provide. HTML is a perfectly good format for reading, printing, and converting. Moreover, anyone paying attention to this repo will realize that we are in serious need of taking steps to simplify website maintenance. We currently have zero team members who are able to build the website on their local machine. Remedying that is an important first step to being able to do anything else.

@github-actions
Copy link
Contributor

Got false positives?

Make changes to the global settings spellcheck.json in /microsoft/TypeScript-Website.

Make changes to this repo's settings in spellcheck.json.

Typos for README.md

Line Typo
4 by the [fourslash test system](https://github.c
82 les, or ancillary files like .d.ts or .map files
918 used as a commonjs import, an esmodule and directly via a script tag
930 is optimized and bundled with Rollup into multiple formats (Common

Typos for The Handbook.md

Line Typo
11 ding trivial interactivity to webpages, JavaScript has grown to be a
11 choice for both frontend and backend applications of every size. W
13 TypeScript is to be a static typechecker for JavaScript programs - in
13 s of the program are correct (typechecked).
26 f the language's features and behaviors.
28 A reader who completes the walkthrough should be able to:
48 gure TypeScript with webpack, rollup, parcel, react, babel, closur
48 arcel, react, babel, closure, lerna, rush, bazel, preact, vue, an
48 babel, closure, lerna, rush, bazel, preact, vue, angular, svelte
48 closure, lerna, rush, bazel, preact, vue, angular, svelte, jquery
48 preact, vue, angular, svelte, jquery, yarn, or npm are out of scop
52 s between TypeScript and your favored programming language, and cle

Generated by 🚫 dangerJS against fe170aa

@andrewbranch andrewbranch merged commit 59a6212 into v2 Nov 29, 2022
@andrewbranch andrewbranch deleted the Remove-playwright branch November 29, 2022 18:53
@orta
Copy link
Contributor

orta commented Nov 30, 2022

This is reasonable , I'd recommend adding a redirect of some sort to the original URLS to the docs root -note - quite a lot of people used the PDFs and just giving a 404 is going to be a surprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants