Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual studio and VS code don't apply tsconfig.json if it uses braces in glob #13062

Closed
scriby opened this issue Dec 20, 2016 · 2 comments
Closed
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript

Comments

@scriby
Copy link

scriby commented Dec 20, 2016

TypeScript Version: 2.1.4

Code

{
  "compilerOptions": {
    "noEmitOnError": true,
    "removeComments": false,
    "experimentalDecorators": true,
    "sourceMap": true,
    "target": "es5",
    "jsx": "react",
    "module": "amd"
  },
  "compileOnSave": true,
  "include": [ "**/*{.ts,.tsx}", "../App", "../Scripts" ],
  "exclude": [ "../App/**/*spec.ts", "../App/**/*.e2e.*ts" ] 
}

Expected behavior:

Decorators can be used without issue in Visual Studio and VS Code for ts/tsx files in the current directory.

Actual behavior:

Visual Studio and VS Code give an error indicating decorators are not supported. The tsc compiler works just fine. Changing "**/*{.ts,.tsx}" to "**/*.ts", "**/*.tsx" works around the error. It appears the glob implementation in VS does not support braces properly.

@DanielRosenwasser
Copy link
Member

Right now curly braces aren't supported in our glob patterns, so that's what you're seeing.

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature labels Dec 30, 2016
@RyanCavanaugh
Copy link
Member

Didn't get any additional feedback on this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants