Assert in Convert to ES module quick fix

[mhegazy]

TypeScript Version: 2.9.0-dev.201xxxxx

Search Terms: assert, convert cjs to es module

Steps to reproduce:

• git clone: https://github.com/mhegazy/webpack.git
• open folder webpack
• open file lib\MainTemplate.js
• hover over require suggestion:

[Error  - 10:44:26 AM] 'getCodeFixes' request failed with error.
Error processing request. Debug Failure. False expression: Changes overlap
Verbose Debug Information: {"pos":1260,"end":11695} and {"pos":3693,"end":3710}
Error: Debug Failure. False expression: Changes overlap
Verbose Debug Information: {"pos":1260,"end":11695} and {"pos":3693,"end":3710}
    at _loop_16 (C:\ls\tsserver.js:98112:34)
    at C:\ls\tsserver.js:98118:25
    at Array.map (native)
    at Object.getTextChangesFromChanges (C:\ls\tsserver.js:98107:86)
    at ChangeTracker.getChanges (C:\ls\tsserver.js:98096:38)
    at Function.ChangeTracker.with (C:\ls\tsserver.js:97692:32)
    at Object.getCodeActions (C:\ls\tsserver.js:98876:64)
    at C:\ls\tsserver.js:98417:121
    at Object.flatMap (C:\ls\tsserver.js:2060:25)
    at Object.getFixes (C:\ls\tsserver.js:98417:23)
    at C:\ls\tsserver.js:105554:35
    at Object.flatMap (C:\ls\tsserver.js:2060:25)
    at Object.getCodeFixesAtPosition (C:\ls\tsserver.js:105552:23)
    at IOSession.Session.getCodeFixes (C:\ls\tsserver.js:113257:64)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (C:\ls\tsserver.js:112053:61)
    at C:\ls\tsserver.js:113423:88
    at IOSession.Session.executeWithRequestId (C:\ls\tsserver.js:113414:28)
    at IOSession.Session.executeCommand (C:\ls\tsserver.js:113423:33)
    at IOSession.Session.onMessage (C:\ls\tsserver.js:113443:35)
    at Interface.<anonymous> (C:\ls\tsserver.js:114702:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)

I also see a similar assert in:

• webpack/lib/ErrorHelpers.js
• webpack/lib/MainTemplate.js
• webpack/lib/HotUpdateChunkTemplate.js
• webpack/lib/RuntimeTemplate.js
• webpack/lib/ContextModuleFactory.js
• webpack/lib/HotModuleReplacementPlugin.js
• webpack/lib/MultiCompiler.js
• webpack/lib/RequireJsStuffPlugin.js
• webpack/lib/optimize/SplitChunksPlugin.js
• webpack/lib/performance/EntrypointsOverSizeLimitWarning.js
• webpack/lib/performance/AssetsOverSizeLimitWarning.js
• webpack/lib/node/NodeSourcePlugin.js
• webpack/lib/node/NodeMainTemplatePlugin.js

Also why are we showing the suggestion in these files.. I thought we have to have at least one file in this project that uses ES6 imports, and as far as I can tell there are none.