getSemanticDiagnostics() returns an undefined "diagnostic" for definition files

[derekcicerone-zz]

I just updated to the latest master (1.5) language services code and I noticed that calling getSemanticDiagnostics() for a definition (.d.ts) file is returning an undefined "diagnostic". Seems like a possible regression unless I shouldn't be calling that function for definition files perhaps?

[DanielRosenwasser]

Hey @derekcicerone, I don't suppose you'd be able to supply us with a file to reproduce the issue, would you?

[derekcicerone-zz]

I'm seeing it on all definition files actually. For example:
https://github.com/borisyankov/DefinitelyTyped/blob/master/underscore/underscore.d.ts

[CyrusNajmabadi]

Could you be more specific as to how you're doing this? Do you have a specific piece of repro code that demonstrates the issue?

"Seems like a possible regression unless I shouldn't be calling that function for definition files perhaps?"

Calling getSemanticDaignostics on a .d.ts file should be fine.

[derekcicerone-zz]

Sure, its from the Eclipse plug-in:
https://github.com/palantir/eclipse-typescript/blob/develop/com.palantir.typescript/bridge/src/languageEndpoint.ts#L109

[DanielRosenwasser]

Unable to repro on our side. I'll give eclipse-typescript a try.

[derekcicerone-zz]

Ah bummer. Ok, lemme know - I can try to set up something more specific if needed - its a bit hard to repro these issues because the bridge requires a few commands to be passed in to reproduce things.

[DanielRosenwasser]

I'm using the develop site specified on your wiki (http://eclipse-update.palantir.com/eclipse-typescript-develop/) and I'm not getting any crashes; should I be? Additionally, what do you use to debug bridge.js?

[derekcicerone-zz]

I usually debug by running Eclipse directly. I can still reproduce the issue with the latest source code. I'll just put in a workaround :(

[mhegazy]

@derekcicerone Can you share the TS code that gives you the undefined diagnostic message?

[derekcicerone-zz]

Its at the top:
https://github.com/borisyankov/DefinitelyTyped/blob/master/underscore/underscore.d.ts

I see this for all .d.ts files.

[CyrusNajmabadi]

Could you set a breakpoint for when an undefined diagnostic is added to the diagnostics collection?