Types not detected if included file includes another file

[danikaze]

Possible bug report (follow-up for 100432)

• VSCode Version: 1.48.2
• OS Version: Windows 10

More details:

Version: 1.48.2 (system setup)
Commit: a0479759d6e9ea56afa657e454193f72aef85bd0
Date: 2020-08-25T10:13:11.295Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362

Steps to Reproduce:

1. Clone the prepared repository to reproduce the issue
2. Open renderer/pages/home.tsx
3. vscode shows the error Cannot find name 'PACKAGE_NAME'.ts(2304) on line 12

It should detect the definition from renderer/td/env.d.ts -- included by renderer/tsconfig.json

Details are also described in the README.md of the repo

Still occurs even running it with code --disable-extensions.

[danikaze]

A bit more of info:

If we remove the import line from renderer/td/env.d.ts and just add its content in the file:

type Foobar = string;

it works

[mjbvz]

I believe this is expected.

Because env.d.ts contains an import statement, the file is considered a module (module variables are not part of the global scope and instead must be explicitly imported)

You can workaround this by explicitly declaring PACKAGE_NAME in the global scope:

import { Foobar } from '../util/foobar';

declare global {
  declare const PACKAGE_NAME: string;
}

declare interface TestWindow extends Window {
  foobar: Foobar;
}

I'll wait for someone on the TS team to confirm before closing this

[RyanCavanaugh]

@mjbvz is correct

[typescript-bot]

This issue has been marked 'Working as Intended' and has seen no recent activity. It has been automatically closed for house-keeping purposes.