-
Notifications
You must be signed in to change notification settings - Fork 13k
Closed
Labels
Domain: Error MessagesThe issue relates to error messagingThe issue relates to error messagingGood First IssueWell scoped, documented and has the green lightWell scoped, documented and has the green lightHelp WantedYou can do thisYou can do this
Milestone
Description
A lot of new error messages use backticks where old messages use single quotes. Errors should use single quotes unless there's a good reason not to.
Specifically,
- Backticks around tsconfig properties and values should use single quotes.
- 7035 has surrounds
declare module '{0}'
with backticks. That is probably correct, but only if the code that fixes the error literally includes a string, likedeclare module "fs" {
- 7040 has a single-quote/backtick mismatch that should just be single quoted.
If this is your first issue, you'll need to change diagnosticMessages.json, then gulp runtests-parallel
followed by gulp baseline-accept
. You should git blame
error 7035 to look at the PR that added it.
DanielRosenwasser and krishnaanaril
Metadata
Metadata
Assignees
Labels
Domain: Error MessagesThe issue relates to error messagingThe issue relates to error messagingGood First IssueWell scoped, documented and has the green lightWell scoped, documented and has the green lightHelp WantedYou can do thisYou can do this