Compiler crash when type name is not nameable

[MaceWindu]

Latest master gives me following error when I try to compile my project:

tsc.js:1907
        var text = getLocaleSpecificMessage(message.key);
                                                   ^
TypeError: Cannot read property 'key' of undefined
    at Object.createFileDiagnostic (tsc.js:1907:52)
    at Object.createDiagnosticForNode (tsc.js:2499:19)
    at Object.writeSymbol (tsc.js:7392:41)
    at writeType (tsc.js:8566:28)
    at writeTypeToTextWriter (tsc.js:8557:20)
    at Object.writeTypeAtLocation (tsc.js:13355:13)
    at emitTypeOfTypeReference (tsc.js:7572:30)
    at emitCommaList (tsc.js:7407:21)
    at emitHeritageClause (tsc.js:7568:21)
    at emitInterfaceDeclaration (tsc.js:7648:21)

[MaceWindu]

when it fails, getHeritageClauseVisibilityError doesn't set diagnosticMessage.
2 errors takes first empty "else" branch
2 errors takes second empty "else" branch
in both cases symbolAccesibilityResult.accessibility == 2 (CannotBeNamed)

[basarat]

TypeError: Cannot read property 'key' of undefined

That's a runtime error. Probably not related to the TypeScript compiler (this github project) and some bug in the code you are debugging.

Are you sure that code works (at runtime) with the old compiler and it fails (consistently) with this version? If so a code diff of the generated JavaScript would help you see what's changed.

[MaceWindu]

it's not my application error, it's failure in compiler itself during compilation

[basarat]

it's failure in compiler itself during compilation

Aaah. Sorry. My bad.

[RyanCavanaugh]

I'm guessing you don't see this for every code file you compile? Can you post some code that causes this error?

[MaceWindu]

Looks like it was fixed by this PR: f622cb4

[MaceWindu]

Arghh, cannot verify it because now latest master gaves me ~100 errors

<SOMETHING> has or is using private name '<SOMETHING_ELSE>'

and SOMETHING_ELSE definitly not private.
I'll try to recheck it all early next week.

[mhegazy]

@MaceWindu can you provide more information, we have recently added these checks so we will need to investigate your scenario.

[MaceWindu]

After some debugging I think I found where it fails.
taken from getAccessibleSymbolChain:

function isAccessible(symbolFromSymbolTable, resolvedAliasSymbol) {
                    if (symbol === (resolvedAliasSymbol || symbolFromSymbolTable)) {
                        return !ts.forEach(symbolFromSymbolTable.declarations, function (declaration) { return hasExternalModuleSymbol(declaration); }) && canQualifySymbol(symbolFromSymbolTable, meaning);
                    }
                }

"if" condition fails here, because symbol and resolvedAliasSymbol are diffrent objects here with diffrent number of declarations items. Symbol from globals has two additional declarations.
I've replaced condition with

var tmp = (resolvedAliasSymbol || symbolFromSymbolTable);
                    if (tmp && (symbol === tmp || symbol.name === tmp.name)) {

And compilation gave no errors to me (so, initial error is really fixed).
Using this information I've managed to reproduce it:
file root.ts

/// <reference path="one.d.ts" />
/// <reference path="two.ts" />
/// <reference path="three.ts" />

file one.d.ts

declare module other {
    class A {
    }
}

file two.ts

module test {
    class B extends other.A {
    }
    export class C {
        private _b: B;
        public getA(): other.A {
            return this._b;
        }
    }
}

file three.ts

declare module other {
    export class AA {
    }
}

build:

tsc -d root.ts

[MaceWindu]

From description #466 looks like fix for this issue