Minimized files ignored in JS projects using jsconfig.json "path"

[rwalle]

Bug Report

🔎 Search Terms

• safe list
• safelist
• minimized file
• .min.js

🕗 Version & Regression Information

TS Server 5.0.4 used in VSCode 1.78.1

⏯ Playground Link

N/A -- only reproducible in projects

💻 Code

https://github.com/rwalle/ts_bug_example

import _ from 'lodash/lodash.min.js';

Our project does not use npm module system. jsconfig.json is correctly set up: https://github.com/rwalle/ts_bug_example/blob/main/dev/apps/app1/jsconfig.json. We import from file directly instead of using package name.

🙁 Actual behavior

lodash.min.js ignored in module import autocompletion suggestion

It seems that all these files including certain jQuery files etc are ignored:

TypeScript/src/server/editorServices.ts

Line 387 in f0ff976

const defaultTypeSafeList: SafeList = {

TypeScript/src/server/editorServices.ts

Line 4112 in f0ff976

if (/^.+[\.-]min\.js$/.test(normalizedNames[i])) {

I can understand why this is done for "regular" JS projects using npm modules or TS projects with or without @types, but this should not be generalized when looking up a file/files in arbitrary JS projects, especially when various options in compilerOptions of jsconfig.json is meant to specifically address such use cases.

🙂 Expected behavior

lodash.min.js should show up just like anotherFile.js.

[RyanCavanaugh]

To be clear, the only bug here is that it doesn't show up in the import auto complete list?

[rwalle]

To be clear, the only bug here is that it doesn't show up in the import auto complete list?

Yes, that is correct

[rwalle]

To be clear, the only bug here is that it doesn't show up in the import auto complete list?

It has been a few days since the last update, I want to follow up and check if this should be tracked as a bug? Thank you.

[RyanCavanaugh]

I would call this the intended behavior. We intentionally filter out .min files from this list because usually that's not what you want to see, and there are often a bunch of .min files and only one correct non-.min import. This is the first I've seen where this behavior wasn't desired, so unless this becomes a more common scenario for some reason, I think we'll leave this as-is.

[microsoft-github-policy-service]

This issue has been marked 'Working as Intended' and has seen no recent activity. It has been automatically closed for house-keeping purposes.