refactor: New file generates import from wrong module specifier #58897

gsk143 · 2024-06-12T03:51:41Z

Does this issue occur when all extensions are disabled?: Yes

Version: 1.90.0 (user setup)
Commit: 89de5a8d4d6205e5b11647eb6a74844ca23d2573
Date: 2024-06-04T19:33:54.889Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

import prisma from "@/prisma/client";
import { NextRequest, NextResponse } from "next/server";
import { z } from "zod";

const createIssueSchema = z.object({
  title: z.string().min(1).max(255),
  description: z.string().min(1),
});

Try refactoring createIssueSchema variable to a new file
2024-06-12 09:20:14.898 [error] <semantic> TypeScript Server Error (5.5.0-dev.20240505) Debug Failure. Error: Debug Failure. at Object.addImportFromExportedSymbol (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:154711:32) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144661:19 at Map.forEach (<anonymous>) at addTargetFileImports (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144655:17) at getNewStatementsAndRemoveFromOldFile (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:143871:3) at doChange4 (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144853:3) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144842:77 at _ChangeTracker.with (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:174963:5) at Object.getRefactorEditsToMoveToNewFile [as getEditsForAction] (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144842:60) at Object.getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:142944:31) at Object.getEditsForRefactor2 [as getEditsForRefactor] (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:150350:32) at IpcIOSession.getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:191692:49) at getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:189914:43) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192078:69 at IpcIOSession.executeWithRequestId (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192070:14) at IpcIOSession.executeCommand (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192078:29) at IpcIOSession.onMessage (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192120:51) at process.<anonymous> (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\tsserver.js:528:14) at process.emit (node:events:514:28) at emit (node:internal/child_process:951:14) at process.processTicksAndRejections (node:internal/process/task_queues:83:21): Error: <semantic> TypeScript Server Error (5.5.0-dev.20240505) Debug Failure. Error: Debug Failure. at Object.addImportFromExportedSymbol (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:154711:32) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144661:19 at Map.forEach (<anonymous>) at addTargetFileImports (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144655:17) at getNewStatementsAndRemoveFromOldFile (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:143871:3) at doChange4 (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144853:3) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144842:77 at _ChangeTracker.with (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:174963:5) at Object.getRefactorEditsToMoveToNewFile [as getEditsForAction] (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:144842:60) at Object.getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:142944:31) at Object.getEditsForRefactor2 [as getEditsForRefactor] (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:150350:32) at IpcIOSession.getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:191692:49) at getEditsForRefactor (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:189914:43) at c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192078:69 at IpcIOSession.executeWithRequestId (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192070:14) at IpcIOSession.executeCommand (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192078:29) at IpcIOSession.onMessage (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\typescript.js:192120:51) at process.<anonymous> (c:\Users\ASUS\.vscode\extensions\ms-vscode.vscode-typescript-next-5.5.20240505\node_modules\typescript\lib\tsserver.js:528:14) at process.emit (node:events:514:28) at emit (node:internal/child_process:951:14) at process.processTicksAndRejections (node:internal/process/task_queues:83:21) at n.create (c:\Users\ASUS\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:1:473136) at v.dispatchResponse (c:\Users\ASUS\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:1:467106) at v.dispatchMessage (c:\Users\ASUS\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:1:465950) at ChildProcess.<anonymous> (c:\Users\ASUS\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\typescript-language-features\dist\extension.js:1:465443) at ChildProcess.emit (node:events:514:28) at emit (node:internal/child_process:951:14) at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
tsc version : 5.4.5

The text was updated successfully, but these errors were encountered:

leonsbuddydave · 2024-06-13T22:27:36Z

Doesn't seem to work when refactoring to an existing file either. I tried creating a new blank file manually and then refactoring to that file but VSCode ignores it.

Version info:

lemomar · 2024-07-06T01:57:17Z

I'm having this problem in a Next.js project as well, is it specific to Next?

nolanleung · 2024-07-07T01:57:03Z

Seems like the culprit is something in ^5.5 breaks refactoring imports from sym-linked packages.

Example (Works in v5.4.5 but not v5.5.2)

Running Refactor: Move to new file on SomeComponent correctly moves it and the Button import to SomeComponent.tsx, and updates the import in SomeOtherComponent.tsx to import { SomeComponent } from './SomeComponent'.

// apps/web/components/SomeOtherComponent.tsx

import { Button } from "@repo/ui";

export function SomeComponent() {
  return (
    <div>
      Some Component
      <Button>Click Me</Button>
    </div>
  );
}


export function SomeOtherComponent() {
  return (
    <div>
      <SomeComponent />
      <div>Some other component</div>
      <CheckList value={[]} options={[]} />
    </div>
  );
}

etiennejcharles · 2024-07-10T15:22:08Z

I'm having this problem in a Next.js project as well, is it specific to Next?

No - It's caused by the typescript version you're using as commented by @nolanleung ealier

In your terminal:

npm i typescript@5.4.5 -D
Then In your command pallette - TypeScript: Select TypeScript Version..
Choose 5.4.5

And try the command, you'll see that it works ✅

corned-beefhash · 2024-07-20T01:07:50Z

I'm having this problem in a Next.js project as well, is it specific to Next?

No - It's caused by the typescript version you're using as commented by @nolanleung ealier

In your terminal:

npm i typescript@5.4.5 -D

Then In your command pallette - TypeScript: Select TypeScript Version..

Choose 5.4.5

And try the command, you'll see that it works ✅

this fixed my issue. for anyone else

Error: <semantic> TypeScript Server Error (5.5.2)
Debug Failure. False expression.
Error: Debug Failure. False expression.
    at getCompletionEntryCodeActionsAndSourceDisplay

i was getting this error when attempting to autoimport certain things. TS server logs showed this

Info 908 [17:52:51.447] response:
{"seq":0,"type":"response","command":"getCodeFixes","request_seq":64,"success":true,"body":[{"fixName":"import","description":"Add import from \"@tanstack/react-table\"","changes":[{"fileName":"[redacted]/column-select-button.tsx","textChanges":[{"start":{"line":3,"offset":1},"end":{"line":3,"offset":1},"newText":"import type { Table } from \"@tanstack/react-table\";\n"}]}]}]}

but it wouldn't actually add any text to my file, even though it showed the correct autoimport in the list.

which means the error was not from TS server? But instead from vscode? Just posting this incase it helps anyone

divmgl · 2024-07-22T16:40:06Z

Also really annoying that the Move to file and Move to new file has been swapped. I've been using Move to new file for years in the first position, why swap it?

anback · 2024-08-03T02:02:20Z

This really screwed up my flow for about to days, downgrading helped. see #58897 (comment)

Ife-Ody · 2024-08-08T18:53:39Z

TypeScript: Select TypeScript Version

This worked for me! Typescript version 5.4.5

vitonsky · 2024-08-10T12:57:48Z

In your terminal:
* `npm i typescript@5.4.5 -D`

* Then In your command pallette - `TypeScript: Select TypeScript Version..`

* Choose `5.4.5`
And try the command, you'll see that it works ✅

It works for me. If someone just faced with this problem - use this workaround

sidouglas · 2024-08-14T03:24:11Z

Does not work for me unfortunately.
I added

"typescript.tsdk": "/Users/simon/.nvm/versions/node/v21.5.0/lib/node_modules/typescript/lib",

as per the docs

output error when moving a Type declaration to a type.ts file.

<semantic> TypeScript Server Error (5.4.5) Debug Failure. False expression: No interactive refactor arguments available Error: Debug Failure. False expression: No interactive refactor arguments available at Object.getRefactorEditsToMoveToFile [as getEditsForAction]
(/Users/simon/.nvm/versions/node/v21.5.0/lib/node_modules/typescript/lib/tsserver.js:140862:11) at Object.getEditsForRefactor
(/Users/simon/.nvm/versions/node/v21.5.0/lib/node_modules/typescript/lib/tsserver.js:139733:31) at getEditsForRefactor2 (/Users/simon/.nvm/versions/node/v21.5.0/lib/node_modules/typescript/lib/tsserver.js:147297:32) at /Users/simon/.vscode/extensions/astro-build.astro-vscode-2.13.3-darwin-arm64/node_modules/astro-ts-plugin-bundle/index.js:5:1884 at Proxy.
<anonymous> (/Users/simon/.vscode/extensions/vue.volar-2.0.28/node_modules/typescript-vue-plugin-bundle/index.js:5:1894) at IpcIOSession.getEditsForRefactor (/Users/simon/.nvm/versions/node/v21.5.0/lib/node_modules/typescript/l...

KostkaBrukowa · 2024-08-19T08:01:13Z

@sidouglas i guess in your case @vue/typescript-plugin plugin is the issue. I've had the same problem, and when I removed this plugin the refactor worked

rsxdalv · 2024-09-10T17:34:34Z

The workaround unfortunately doesn't work as smoothly if you don't have a node_modules in the current workspace root, i.e., if you have a monorepo with another sub folder.

I also tried the nightly version (via extension typescript nightly) 5.7 and it's broken too. If I do move to file I at the very minimum least see an error. But trying to move to a new file anything bigger than a constant number fails.

goncalossantos · 2024-09-12T10:14:08Z

This was also happening to me due to the default VSCode version of TS, even though I was working without typescript on a js file. Doing the steps above and then changing the tsdk version fixed it for me

iisaduan · 2024-10-24T00:06:10Z

Minimal repro:

/// <reference path='fourslash.ts' />

// @Filename: /node_modules/zod/types.d.ts
//// declare const objectType: () => {};
//// 
//// export { objectType as object };

// @Filename: /node_modules/zod/external.d.ts
//// export * from "./types";

// @Filename: /node_modules/zod/index.d.ts
//// import * as z from "./external";
//// export * from "./external";
//// export { z };
//// export default z;

// @Filename: /test.ts
//// import { z } from "zod";
//// 
//// [|const createIssueSchema = z.object();|]

verify.moveToNewFile({
    newFileContents: {
        "/test.ts":
`
`,

        "/createIssueSchema.ts":
`import { z } from "zod";


const createIssueSchema = z.object();
`,
    },
});

MoveToNewFile should stop crashing after #60333, but the minimal repro will generate that z is imported from zod/external instead of just z

laugri · 2024-11-12T08:42:54Z

Then In your command pallette - TypeScript: Select TypeScript Version..

For those like me that don't understand why they don't have the entry showing up in their command palette, your focused tab has to be a .ts(x) file.

magicdawn · 2024-11-20T08:27:01Z

Then In your command pallette - TypeScript: Select TypeScript Version..

For those like me that don't understand why they don't have the entry showing up in their command palette, your focused tab has to be a .ts(x) file.

This is another problem, I use "restart ts server" a lot, since problems with ts server can not auto recover, I have to manual restart.
I have to open a ts/tsx file then use the command palette to restart.
why not showing these entries for whole workspace if ts server is running ? @the Team ???

magicdawn · 2024-11-24T09:12:26Z

"move to file" / "move to new file" still not working on TypeScript v5.5 v5.6 & latest v5.7.2

"move" works on v5.4, but TS v5.5 Inferred Type Predicates is really awesome, Can't leave this.

iisaduan · 2024-11-25T17:42:36Z

@magicdawn since your crash still happens on 5.7, will you open a new issue with your repro? The case originally reported in this thread should no longer crash in 5.7, and I'd need to investigate your case separately

vscodenpa assigned mjbvz Jun 12, 2024

mjbvz transferred this issue from microsoft/vscode Jun 17, 2024

RyanCavanaugh assigned navya9singh and unassigned mjbvz Jun 18, 2024

RyanCavanaugh added the Bug A bug in TypeScript label Jun 18, 2024

RyanCavanaugh added this to the TypeScript 5.6.0 milestone Jun 18, 2024

DanielRosenwasser added the Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output label Jul 2, 2024

DanielRosenwasser mentioned this issue Jul 2, 2024

move to new file code action results in TS server error #59118

Closed

justschen mentioned this issue Jul 9, 2024

Move to a new file is no longer working microsoft/vscode#219704

Closed

justschen mentioned this issue Jul 11, 2024

move to file does not work in Remix.js projects microsoft/vscode#221505

Closed

lifeiscontent mentioned this issue Jul 15, 2024

Move to file and Move to a new file not works microsoft/vscode#221539

Closed

sakamossan mentioned this issue Jul 31, 2024

TS error moving a function to another file #59284

Closed

jamdelion mentioned this issue Aug 7, 2024

feat: Add new team editor - button and modal only theopensystemslab/planx-new#3495

Merged

This was referenced Oct 22, 2024

DRAFT namespace autoimport for move to file iisaduan/TypeScript#5

Closed

fix autoimports crash: generate namespace and other module symbol imports #60333

Merged

iisaduan mentioned this issue Oct 24, 2024

<semantic> TS Server Error Debug Failure when moving to a js file #59240

Open

iisaduan changed the title ~~refactor: New file doesn't work~~ refactor: New file generates import from wrong module specifier Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: New file generates import from wrong module specifier #58897

refactor: New file generates import from wrong module specifier #58897

gsk143 commented Jun 12, 2024 •

edited

Loading

leonsbuddydave commented Jun 13, 2024

lemomar commented Jul 6, 2024

nolanleung commented Jul 7, 2024 •

edited

Loading

etiennejcharles commented Jul 10, 2024 •

edited

Loading

corned-beefhash commented Jul 20, 2024 •

edited

Loading

divmgl commented Jul 22, 2024

anback commented Aug 3, 2024

Ife-Ody commented Aug 8, 2024

vitonsky commented Aug 10, 2024

sidouglas commented Aug 14, 2024 •

edited

Loading

KostkaBrukowa commented Aug 19, 2024

rsxdalv commented Sep 10, 2024

goncalossantos commented Sep 12, 2024

iisaduan commented Oct 24, 2024

laugri commented Nov 12, 2024

magicdawn commented Nov 20, 2024

magicdawn commented Nov 24, 2024

iisaduan commented Nov 25, 2024

refactor: New file generates import from wrong module specifier #58897

refactor: New file generates import from wrong module specifier #58897

Comments

gsk143 commented Jun 12, 2024 • edited Loading

leonsbuddydave commented Jun 13, 2024

lemomar commented Jul 6, 2024

nolanleung commented Jul 7, 2024 • edited Loading

Example (Works in v5.4.5 but not v5.5.2)

etiennejcharles commented Jul 10, 2024 • edited Loading

corned-beefhash commented Jul 20, 2024 • edited Loading

divmgl commented Jul 22, 2024

anback commented Aug 3, 2024

Ife-Ody commented Aug 8, 2024

vitonsky commented Aug 10, 2024

sidouglas commented Aug 14, 2024 • edited Loading

KostkaBrukowa commented Aug 19, 2024

rsxdalv commented Sep 10, 2024

goncalossantos commented Sep 12, 2024

iisaduan commented Oct 24, 2024

laugri commented Nov 12, 2024

magicdawn commented Nov 20, 2024

magicdawn commented Nov 24, 2024

iisaduan commented Nov 25, 2024

gsk143 commented Jun 12, 2024 •

edited

Loading

nolanleung commented Jul 7, 2024 •

edited

Loading

etiennejcharles commented Jul 10, 2024 •

edited

Loading

corned-beefhash commented Jul 20, 2024 •

edited

Loading

sidouglas commented Aug 14, 2024 •

edited

Loading