Salsa: symbols not found (ES5)

[egamma]

From @warpdesign on February 17, 2016 11:21

I have activated salsa and when activated, some symbols cannot be found anymore in ES5 files.

For example, if I have a a file with only:

function toto() {
}

Typing @totowill work and highlight the toto function.

But if I wrap the code into a closure, it doesn't work anymore:

Without salsa, it works as expected, highlighting the toto function even if it is wrapped into a closure.

Code 0.10.8
Windows 10

Copied from original issue: microsoft/vscode#3079

[egamma]

Moving to TypeScript

[billti]

This is interesting, as the nested function lives within an expression, not nested function declarations. Need to discuss how we would display these (if desired). for example, currently we show the parent declaration to disambiguate, but in this case, it lives within an anonymous function expression.

[warpdesign]

What is the status of this particular problem ?

The fact that Code doesn't detect symbol in this case means it cannot be used with any code wrapped into closure.

A lot of ES5 source code has been written like this.

[kuechlerm]

As the update is due today, is it possible to not use Salsa?

I really like to use folding but this issue is a huge step back! My current project uses IIFEs everywhere ...

[egamma]

As the update is due today, is it possible to not use Salsa?

@kuechlerm this update supports only Salsa and this is not possible, sorry.