Make goto-definition go to a signature declaration if possible #10593
Conversation
ghost
force-pushed
the
goto_definition_super
branch
from
6f2567e to
4514f8f
Compare
| return node && node.parent && node.parent.kind === SyntaxKind.NewExpression && (<CallExpression>node.parent).expression === node; | ||
| } | ||
|
|
||
| function getCallOrNewExpressionWorker(node: Node, kind: SyntaxKind): Node | undefined { |
There was a problem hiding this comment.
Change the type of kind to SyntaxKind.CallExpression | SyntaxKind.NewExpression
There was a problem hiding this comment.
We'd need to do a new LKG before using enums-as-unions.
|
For the record, calls and If it's not too hard, it'd be ideal to keep the behavior consistent between them. |
|
Can you also add a test for going to definition on a call where overload resolution failed? declare function doStuff(n: number): number;
declare function doStuff(s: string): string;
/**/doStuff(true);Ideally, the language service should still jump to one of the overloads. |
ghost
assigned
| function getAncestorCallLikeExpression(node: Node): CallLikeExpression | undefined { | ||
| const target = climbPastManyPropertyAccesses(node); | ||
| const callLike = target.parent; | ||
| return isCallLikeExpression(callLike) && getInvokedExpression(callLike) === target && callLike; |
There was a problem hiding this comment.
Put callLike first to bail early
| function getAncestorCallLikeExpression(node: Node): CallLikeExpression | undefined { | ||
| const target = climbPastManyPropertyAccesses(node); | ||
| const callLike = target.parent; | ||
| return callLike && isCallLikeExpression(callLike) && getInvokedExpression(callLike) === target && callLike; |
There was a problem hiding this comment.
Seems you are checking callLike twice
There was a problem hiding this comment.
First one is checking whether it exists. Last one is returning it from the function.
|
Other than the comments, 👍 |
Fixes #9269 and #10074