Fix misleading error TS2410 from issue #10601 #11176
Conversation
|
Hi @lukaselmer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| @@ -1279,7 +1279,7 @@ | |||
| "category": "Error", | |||
| "code": 2409 | |||
| }, | |||
| "All symbols within a 'with' block will be resolved to 'any'.": { | |||
| "Unsupported 'with' statement, all symbols within a 'with' block will be resolved to 'any'.": { | |||
There was a problem hiding this comment.
I would word the error as "The 'with' statement is not supported. All symbols in a 'with' block will have type 'any'."
| if (!hasParseDiagnostics(sourceFile)) { | ||
| const start = getSpanOfTokenAtPosition(sourceFile, node.pos).start; | ||
| const end = node.statement.pos; | ||
| grammarErrorAtPos(sourceFile, start, end - start, Diagnostics.Unsupported_with_statement_all_symbols_within_a_with_block_will_be_resolved_to_any); |
There was a problem hiding this comment.
How bad is the error span if you just say error(node, ...) ? It would save a lot of fiddly code. But I suspect that it underlines the entire with block.
There was a problem hiding this comment.
Yes, it underlines the whole with block. Therefore I would still go with this solution.
Fixes #10601
'Bug' or 'Accepting PRs' or is in the Community milestone: see Misleading error TS2410 #10601
masterbranchjake runtestslocally: No, tslint did not run when I checked out the project. The tests run though.