Skip to content

remove redundant type assertion #11347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2016
Merged

remove redundant type assertion #11347

merged 1 commit into from
Oct 10, 2016

Conversation

HerringtonDarkholme
Copy link
Contributor

Just find an unnecessary assertion while browsing code

@HerringtonDarkholme
Copy link
Contributor Author

ping @mhegazy @rbuckton

@RyanCavanaugh RyanCavanaugh merged commit fe32282 into microsoft:master Oct 10, 2016
@RyanCavanaugh
Copy link
Member

Thanks!

If you want some low-hanging fruit for a fun PR, it's fairly easy to hack in an error report when the asserted type is identical to the expression type.

@HerringtonDarkholme HerringtonDarkholme deleted the remove-redundant branch October 18, 2016 06:22
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HerringtonDarkholme @RyanCavanaugh @msftclas