Skip to content

Emit of union type metadata for decorator to use constituent serialized type if its identifier and same across all constituent types #11391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2016
Merged

Emit of union type metadata for decorator to use constituent serialized type if its identifier and same across all constituent types #11391

merged 5 commits into from
Oct 6, 2016

Conversation

sheetalkamat
Copy link
Member

Fixes #10809

@mhegazy
Copy link
Contributor

mhegazy commented Oct 5, 2016

can you also add a test for enum literal types.

@sheetalkamat sheetalkamat merged commit 7555f60 into master Oct 6, 2016
@sheetalkamat sheetalkamat deleted the metaDataWithStringLiteral branch October 6, 2016 02:21
@aluanhaddad aluanhaddad mentioned this pull request Dec 7, 2016
Closed
@dqweek dqweek mentioned this pull request Dec 7, 2016
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheetalkamat @mhegazy @wizarrc @msftclas