Mark "React" symbol as referenced #11721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if there was no error message being displayed Fixes #10312
mhegazy
reviewed
Oct 19, 2016
| //@noUnusedLocals:true | ||
| //@noUnusedParameters:true | ||
| //@module: commonjs | ||
| //@jsx: react |
There was a problem hiding this comment.
can you add a test for reactNamesapce and noUnusedLocals
mhegazy
reviewed
Oct 19, 2016
| @@ -0,0 +1,23 @@ | |||
| //@noUnusedLocals:true | |||
| //@noUnusedParameters:true | |||
There was a problem hiding this comment.
you do not need the unused params here.
mhegazy
approved these changes
Oct 19, 2016
mhegazy
approved these changes
Oct 19, 2016
|
what about custom JSX backend using |
yup. see the test in https://github.com/Microsoft/TypeScript/blob/67873ca20b334c0b21e2a70440ab431a8b4bc41b/tests/cases/compiler/unusedImports15.ts |
|
It seems, that it doesn't work with new jsxFactory param in tsconfig.json. Can somebody confirm this? Should I open new issue? |
yes please. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It won't not be marked as
isReferencedinresolveNamewhen there is nodiagnosticMessagewhen resolving it.Fixes #10312