Fix object spread+async emit #12223
Merged
Fix object spread+async emit #12223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Retain function modifiers. They were previously dropped. 2. Do not emit __assign for object literals with no spreads, just visit children. 3. call aggregateTransformFlags after creating an __assign call.
|
@rbuckton can you take a look. |
rbuckton
approved these changes
Nov 15, 2016
| @@ -256,7 +260,7 @@ namespace ts { | |||
| visitEachChild(node.body, visitor, context); | |||
| return setOriginalNode( | |||
| createFunctionExpression( | |||
| /*modifiers*/ undefined, | |||
| node.modifiers, | |||
There was a problem hiding this comment.
You don't seem to be visiting methods or accessors in this transformer.
There was a problem hiding this comment.
Hmm. Good point. I'll confirm that they don't work and put them in a separate PR I think.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12203