Make some code in checker neater #12862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Dec 12, 2016
| @@ -1100,7 +1098,7 @@ namespace ts { | |||
| } | |||
|
|
|||
| function getDeclarationOfAliasSymbol(symbol: Symbol): Declaration | undefined { | |||
| return forEach(symbol.declarations, d => isAliasSymbolDeclaration(d) ? d : undefined); | |||
| return find<Declaration>(symbol.declarations, isAliasSymbolDeclaration); | |||
There was a problem hiding this comment.
symbol.declarations is Declaration[] but isAliasSymbolDeclaration takes a Node. It's odd that this infers Node as the type. Should this be an issue?
There was a problem hiding this comment.
Probably yes -- I would think that symbol.declarations would be the one providing the type for inference. It's worth investigating even if it ends up being by design.
ghost
force-pushed
the
neater_checker
branch
from
a9decf6 to
891159c
Compare
sandersn
approved these changes
Dec 13, 2016
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.