#13063 Fix strictNullChecks breaking typeof #13192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow typeof to use not-auto variable in strictNullChecks mode
| @@ -10372,7 +10372,7 @@ namespace ts { | |||
| // the entire control flow graph from the variable's declaration (i.e. when the flow container and | |||
| // declaration container are the same). | |||
| const assumeInitialized = isParameter || isOuterVariable || | |||
| type !== autoType && type !== autoArrayType && (!strictNullChecks || (type.flags & TypeFlags.Any) !== 0) || | |||
| type !== autoType && type !== autoArrayType && (!strictNullChecks || isInTypeQuery(node) || (type.flags & TypeFlags.Any) !== 0) || | |||
There was a problem hiding this comment.
Please put this condition last in the || chain - we want the faster checks first and isInTypeQuery has to walk up the entire tree
There was a problem hiding this comment.
@RyanCavanaugh updated pull request
Add isInTypeQuery as the last OR
mhegazy
approved these changes
Dec 28, 2016
RyanCavanaugh
approved these changes
Dec 28, 2016
vladima
approved these changes
Dec 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13063