Skip to content

Fix keyof with union or intersection constraint #13419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2017
Merged

Fix keyof with union or intersection constraint #13419

merged 3 commits into from
Jan 11, 2017

Conversation

ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Jan 11, 2017 •
edited by DanielRosenwasser
Loading

Fixes #13102.

Also, this PR removes an incorrect type relationship. Previously, given a type K extends keyof T, we would consider a type S assignable to K if S is assignable to keyof T. We no longer to that.

@ahejlsberg ahejlsberg merged commit 04da707 into master Jan 11, 2017
@ahejlsberg ahejlsberg deleted the fixKeyofWithIntersectionConstraint branch January 11, 2017 23:15
@keylocation-bot keylocation-bot mentioned this pull request Jan 12, 2017
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahejlsberg @mhegazy @msftclas