Optimize signature relationship checks #15519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 2, 2017
|
Ported to release-2.3 in 5c56b4c |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes signature relationship checks in instantiations of the same type. In general, when comparing signatures from two types we perform N * M comparisons which becomes quite expensive in types with many signatures (such as the types of methods with many overloads). In #12548 we added a number of new overloads in
Array<T>which caused a severe regression when structurally comparing array-like types (such as tuples). Now, when comparing signatures from instantiations of the same type, we simply compare the two lists of signatures pairwise. This reduces the check time for the example in #15470 from 7-8s to 0.4s.Fixes #15470.