Skip to content

Port checkJs fix from master #16227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 2, 2017
Merged

Port checkJs fix from master #16227

merged 7 commits into from
Jun 2, 2017

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jun 2, 2017

Was #16210.

@amcasey amcasey requested review from billti and mhegazy June 2, 2017 20:51
@msftclas
Copy link

msftclas commented Jun 2, 2017

@amcasey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@amcasey
Copy link
Member Author

amcasey commented Jun 2, 2017 

Running tests on 8 threads...

  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (55s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (54s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (42s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6760 passing (54s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (57s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (51s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 6761 passing (57s)
  [▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬] √ 7588 passing (59s)

  54914 passing (7m)

amcasey
amcasey commented Jun 2, 2017
View reviewed changes
src/compiler/core.ts
/** The version of the TypeScript compiler release */
export const version = "2.3.4";
export const version = "2.3.5";
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the line ending matter? I'm not sure how it changed, but I can revert it.

@amcasey
Copy link
Member Author

amcasey commented Jun 2, 2017

Confirmed that the failure is due to the absence of an npm 5 workaround merged into master but not release-2.3.

@amcasey amcasey merged commit a952c19 into microsoft:release-2.3 Jun 2, 2017
@amcasey amcasey deleted the release-2.3 branch September 7, 2017 23:34
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy Awaiting requested review from mhegazy

1 more reviewer

@billti billti billti approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amcasey @msftclas @billti