Skip to content

Add alwaysStrict option #16562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2017
Merged

Add alwaysStrict option #16562

merged 4 commits into from
Jun 29, 2017

Conversation

t-mrt
Copy link
Contributor

@t-mrt t-mrt commented Jun 15, 2017

Fixes #16531

@msftclas
Copy link

@t-mrt,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@t-mrt t-mrt mentioned this pull request Jun 15, 2017
Merged
@t-mrt
Copy link
Contributor Author

t-mrt commented Jun 15, 2017 •
edited
Loading

Travis CI build failed. I will correct this shortly.

@DanielRosenwasser
Copy link
Member

Can you also add these to the tsconfig.jsons of each directory?

@t-mrt
Copy link
Contributor Author

t-mrt commented Jun 21, 2017

review please.

@DanielRosenwasser
Copy link
Member

@weswigham can you look at this?

@weswigham
Copy link
Member

Are all the whitespace changes required? They are adding a lot of noise. Other than removing that, it looks good.

weswigham
weswigham requested changes Jun 29, 2017
View reviewed changes
src/harness/unittests/textChanges.ts
@@ -367,20 +367,22 @@ namespace M {
changeTracker.insertNodeAfter(sourceFile, findChild("M", sourceFile), createTestClass(), { prefix: newLineCharacter });
});
}
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still these whitespace changes, too

Copy link
Contributor Author

@t-mrt t-mrt Jun 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed {} because function declarations cannot be nested inside a statement or block in strict mode. This is not cosmetic change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Ok!

@weswigham weswigham merged commit 51fb7e9 into microsoft:master Jun 29, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham weswigham requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-mrt @msftclas @DanielRosenwasser @weswigham