Skip to content

In getDeclarationSpaces, treat a type alias as a SymbolFlags.Type, not a SymbolFlags.Value #16624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jul 11, 2017
Merged

In getDeclarationSpaces, treat a type alias as a SymbolFlags.Type, not a SymbolFlags.Value #16624

1 commit merged into from
Jul 11, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2017 •
edited by ghost
Loading

Fixes #16596
We will no longer produce an error message for:

type t = number;
export const t = 0;

Previously we had an error in this case but not for interface.

@ghost ghost force-pushed the declarationSpaces branch from a868c59 to e7911b8 Compare June 20, 2017 17:13
@ghost ghost merged commit f45ccf5 into master Jul 11, 2017
@ghost ghost deleted the declarationSpaces branch July 11, 2017 16:54
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @msftclas