Clean up uses of ensureScriptKind #16714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sandersn
reviewed
Jun 28, 2017
| scriptKind = host.getScriptKind(fileName); | ||
| } | ||
| if (!scriptKind) { | ||
| scriptKind = getScriptKindFromFileName(fileName); |
There was a problem hiding this comment.
is host.getScriptKind the same as getScriptKindFromFileName here? If not, where is host.getScriptKind defined? (I'm trying to figure out why you removed the fallback to getScriptKindFromFileName.)
There was a problem hiding this comment.
There's some complex logic here, but I think what I did is equivalent. In both cases:
- If
host.getScriptKind(fileName)is defined, uses that. - Else, uses
getScriptKindFromFileName(fileName). - If that fails, uses
ScriptKind.TS.
ensureScriptKind itself handles falling back to getScriptKindFromFileName, so there's no need to do that here.
There was a problem hiding this comment.
Ah, point 3 is what I missed. Thanks.
sandersn
approved these changes
Jun 28, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some uses of this function were overly complicated or unnecessary.