Skip to content

Improvements to LineIndex.edit #17056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jul 10, 2017
Merged

Improvements to LineIndex.edit #17056

2 commits merged into from
Jul 10, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2017

  • Check for pos < this.root.charCount() is unnecessary, because we just checked if (pos >= this.root.charCount()) { pos = this.root.charCount() - 1; ... }.
  • checkEdits was broken -- this.getText isn't changed by this method, a new lineIndex is created instead.

@ghost ghost requested a review from sheetalkamat July 10, 2017 15:02
@ghost ghost merged commit e29b210 into master Jul 10, 2017
@ghost ghost deleted the edit branch July 10, 2017 22:09
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheetalkamat @msftclas