jsTyping: Better logging for addInferredTypings #17249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
force-pushed
the
addInferredTypings
branch
from
be5aa77 to
ada5461
Compare
jramsay
reviewed
Jul 27, 2017
| } | ||
| } | ||
| addInferredTypings(packageNames, " Found package names"); |
There was a problem hiding this comment.
Any reason for the additional spacing here before Found?
There was a problem hiding this comment.
I wanted to imply that this was part of the above log for "searching for typing names"; should also indent anything else in that part.
jramsay
reviewed
Jul 27, 2017
| @@ -22,6 +22,7 @@ namespace ts.JsTyping { | |||
| name?: string; | |||
| optionalDependencies?: MapLike<string>; | |||
| peerDependencies?: MapLike<string>; | |||
| types?: string; | |||
There was a problem hiding this comment.
good catch - these could be specified as types or typings
jramsay
approved these changes
Jul 28, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequel to #16652